Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mohammad Idham #10

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Mohammad Idham #10

wants to merge 5 commits into from

Conversation

midham14
Copy link

@midham14 midham14 commented Oct 8, 2020

  1. Add Register Server
  2. Add Login Server
  3. Add Get Tasks Server
  4. Add Post Tasks Server
  5. Add Edit Tasks Server
  6. Add Delete Tasks Server
  7. add api-documentation
  8. add client login,register,logout,googlelogin
  9. add client crud add task, edit category, delete task, get task
  10. add server google login

client deploy : https://kanban-idham.web.app/
server deploy : https://kanban-idham.herokuapp.com/

2. Add Login Server
3. Add Get Tasks Server
4. Add Post Tasks Server
5. Add Edit Tasks Server
6. Add Delete Tasks Server
7. add api-documentation
@ziterz ziterz self-requested a review October 9, 2020 03:09
server/app.js Outdated
@@ -0,0 +1,28 @@
require('dotenv').config()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nanti kalau deploy kasih conditional ya



class TaskController{
static getTaskHandler(req,res,next){
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get tasknya aman ya? nanti difilter di client

@@ -0,0 +1,32 @@
const { User } = require('../models')
Copy link

@ziterz ziterz Oct 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

authentication aman yaa

@@ -0,0 +1,24 @@
const { Task } = require('../models')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

authorization aman yaa

Copy link

@ziterz ziterz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Udah lumayan yaa 👍🏻

2. add client crud add task, edit category, delete task, get task
3. add server google login
note : belum setting deploy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants