Fix crash on nil/invalid URL (iOS) #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexV525
changed the title
|
If you want, as the maintainer is out for quite a long time now, we are maintaining this fork: feel free to add you PR on this fork if you want. |
This was referenced Jul 6, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection with issue(s)
No unsolved issue, but might be similar to #74 and #174 .
Testing and Review Notes
Pass a url include whitespace (e.g. 'https://www.google.com '), app will crash immediately.
By adding this, there're still many codes using
!for force parsing, it require further modification.To Do
Nothing needs to be handled.