Fix NULL reference in CucumberJSON results processing #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…step. The background step will have no results and so a null reference is raised on Line 111:CucumberJsonSingleResults.cs. The actual results for this step are within the scenario elements of the JSON. Suggested fix is to remove the background element from the feature when processing results.
|
Hi, Thanks for taking the time to report this and provide a fix. Would it be at all possible for you to provide a test as well that demonstrates the problem? Your fix would then make the test pass. Thanks! |
* Minor typo change in the test file
|
Unfortunately the solution isn't as simple as that, because the Ruby version of Cucumber does include the background steps and their results as separate elements. I created an issue to track and solve this problem: #293 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cucumber-JS creates JSON results files that may include a background step. The background step will have no results and so a null reference is raised on Line 111:CucumberJsonSingleResults.cs.
The actual results for this step are within the scenario elements of the JSON.
Suggested fix is to remove the background element from the feature when processing results.