Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue with Scenario Outline Data Containing Parenthesis #299

Merged
merged 3 commits into from
Mar 1, 2016
Merged

Fix Issue with Scenario Outline Data Containing Parenthesis #299

merged 3 commits into from
Mar 1, 2016

Conversation

ocsurfnut
Copy link

We found an issue when the scenario outline examples included () characters the Regex match did not work correctly, and the scenario was flagged as inconclusive. Adding some \ escaping fixed the issue.

@dirkrombauts
Copy link
Member

Thanks for this contribution.

I try to follow a strict test-first policy for new contributions to the .NET code, so I would like to ask you to provide unit tests as well. I added a new section to the CONTRIBUTING.md file to describe what I expect. If you have any questions after reading it, please ask me and I will try to explain more clearly.

@ocsurfnut
Copy link
Author

I've included the new test results from pickles-testresults (see PR picklesdoc/pickles-testresults#14) as well as the unit tests and implementation to make them pass. Hopefully this makes the PR more complete.

@dirkrombauts
Copy link
Member

This is exactly the way I wanted it! Two more additions will make it perfect:

  • Yesterday I introduced a new test result provider, VsTest. Please add a method to its derivation of StandardTestSuite as well. You'll need to rebase your branch on the current develop branch.
  • Please add an entry to CHANGELOG.md, under the Unreleased header in a section called "Fixed".

If you have merge issues with the test result files: overwrite them with your version :-)

@ocsurfnut
Copy link
Author

  • added implementation and tests for VsTest result provider.
  • added entry to CHANGELOG.md.

@dirkrombauts
Copy link
Member

Thanks - it's bedtime in my time zone so I will look into this tomorrow. Based on our collaboration so far I think it will be fine, and I'll release a new version of Pickles in time for your next work day :-)

dirkrombauts added a commit that referenced this pull request Mar 1, 2016
Fix Issue with Scenario Outline Data Containing Parenthesis
@dirkrombauts dirkrombauts merged commit 94772e5 into picklesdoc:develop Mar 1, 2016
@dirkrombauts
Copy link
Member

Many thanks!

@dirkrombauts
Copy link
Member

Released in v2.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants