-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wildcard support for test result files #421
Conversation
* Fixes hiding topnav when printing. (#411) * Adding Cucumber JSON Documentation Builder (#413) * Adding Cucumber JSON as possible export format * Version * fixing the tests * Fixing unit tests * Separated Cucumber Documentation as separate project * Fixing Build Pipeline * Adding missed build dependency steps * resolved the namespace issues that was preventing the build from completing successfully * Addressing code review comments * adding cucumber output format * Release 2.12.0 (#416) * Adding entries to change log * Bump version (2.12.0) * Version 2.12.0
Thank you for your contribution! Would you be willing to expand your work - for example I would be grateful if you could address the limitations that you discovered in the existing code. Also: as you discovered the usage of semicolons isn't uniform. It would be great if you could make this more general. |
I can look into it and create testcases for relative and UNC paths. Difficulty is that I experienced the filesystem mock a bit limited to do this, but maybe I have not read enough into it. Otherwise I need to setup some tests on a real filesystem, but can be brittle on other users system because different setups. Questions:
I'll take a look into the UI behaviour for feasibility. |
Hi,
|
…mandLine, UI-api). Folders and no match will deliver no result file. Multiple matches on the same file will distinct into a single result.
Improved the handling of wildcard support and semicolons by adding them to the MSBuild and UI parts. The UI still needs a solution on the front end, but it is already implemented on the back end. When there are multiple matches on the same file (like C:\foo*.trx;C:*bar.trx matches twice on C:\foobar.trx) it is rendered into a single match. When there are no matches, no error is thrown in the file-collection functions. This is the same behaviour as before. Unfortunately, I checked in too many files (some config and test result files), is there a way you can ignore this? |
Thanks for your continuing efforts. About the files. There's some merge conflict on the build server ... I think the best thing would be for you to rebase on develop and reapply your changes ... |
…mandLine, UI-api). Folders and no match will deliver no result file. Multiple matches on the same file will distinct into a single result. This commit does not include the changed trx files that made the merge difficult
…mandLine, UI-api). Folders and no match will deliver no result file. Multiple matches on the same file will distinct into a single result. Attempt 3
…ild, CommandLine, UI-api)." This reverts commit 1dc1861.
…mandLine, UI-api). Folders and no match will deliver no result file. Multiple matches on the same file will distinct into a single result. This commit does not include the changed trx files that made the merge difficult
Closing this request, I am messing up with my GitHub settings. Will do a new pull request. |
Wildcards can be used for testresult files like:
C:\results*.trx
or
C:\runs\Acceptance*.xml;C:\dev\unit*.xml
Works in combination with semicolon.
Multiple files are selected as wildcard matches more than one files.
All tests pass, new tests added.
Commandline use tested in the wild.
Code is implemented for commandline, powershell, msbuild and for future use in UI*. All other behaviour in these configs is kept the same (like: semicolon use is only implemented for commandline).
* UI does a check on the existing of the file before the GENERATE button becomes enabled. This does not work wild wild cards.
Known Limitations:
Above limited behaviour is not described or tested in the master version, please advice.