-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pickles is unable to deal with Danish characters #477
Conversation
…s. Fallback is default encoding.
…These rules ar now included.
Thanks for this extension! Could you please provide unit tests as well? Thanks |
I will try. What about the test harness? I don't have that up and running,
yet.
/Philip
…On Thu, 3 Aug 2017 at 20.10, Dirk Rombauts ***@***.***> wrote:
Thanks for this extension! Could you please provide unit tests as well?
Thanks
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#477 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABNygYl4u2pK0jKHuZ85udcKwAxw9wVuks5sUg0MgaJpZM4OseZ6>
.
|
The test harness is a separate solution in the same repository. You need to install a few non-standard components for that, I'm afraid. The Contributing.md should contain the info you need to get started. If there's something missing or unclear, please let me know so I can adapt it. |
I will give it a try.
…On Thu, 3 Aug 2017 at 20.25, Dirk Rombauts ***@***.***> wrote:
The test harness is a separate solution in the same repository. You need
to install a few non-standard components for that, I'm afraid.
The Contributing.md
<https://github.com/picklesdoc/pickles/blob/develop/CONTRIBUTING.md>
should contain the info you need to get started. If there's something
missing or unclear, please let me know so I can adapt it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#477 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABNygQFZ1Gza8kb_6rY_5iQvW1VNcADoks5sUhCpgaJpZM4OseZ6>
.
|
…s. (Cucumber, MsTest, NUnit, SpecRun, VsTest and XUnit). Test for Cucumber (Ruby) and CucumberJS is ignored. I havent been able to generate testresults (CucumberJson) for these scenarios.
Thanks for the update! I'll have a look soon and see whether I can do something about the Ruby and JS results. If I can, I'll add them to your pull request. |
I'm not able to generate test-output for Cucumber (Ruby) and CucumberJS. The Json files are empty Regarding converting special characters, It could have been made more general, by using the converter from Specflow. You can see the code used in SpecFlow here |
I got the Cucumber Ruby results to work, and I added an entry to the change log. I had to merge changes from the upstream develop branch. The Cucumber JS test results are a bit of a mystery still - they don't work at all (the ruby ones only didn't pick up the Danish stuff). I'll need to investigate that more. |
Thanks for looking into it.
I hope to be able to use the test result with Danish specifications, to
have focus on test automation.
…On Wed, 9 Aug 2017 at 20.11, Dirk Rombauts ***@***.***> wrote:
I got the Cucumber Ruby results to work, and I added an entry to the
change log. I had to merge changes from the upstream develop branch.
The Cucumber JS test results are a bit of a mystery still - they don't
work at all (the ruby ones only didn't pick up the Danish stuff). I'll need
to investigate that more.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#477 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABNygdUAHyyRl9hbwxQpoQO6NLODm83Oks5sWfZhgaJpZM4OseZ6>
.
|
Hi |
I hope to have something by the end of the week, but I can't guarantee anything. I can get the CucumberJS results to work with some manual editing, but I'd like to get to the bottom of it because otherwise the next time we change the test results we'll have the same issue. |
Thanks for your contribution and patience. I hope to release a new version in the coming days, but you can compile your own from source in the meantime. |
* Pickles is unable to deal with Danish characters (#477) * Version 2.16.2
Released in version 2.16.2 |
* Version 2.16.2 (#483) * Pickles is unable to deal with Danish characters (#477) * Version 2.16.2 * Version 2.17.0 * Add technicalTags to exclude technical tags in report but keep feature * fix on tehcnicalTags * add tests * Version 2.18.1 * update property name to HideTags * fix forgotten files following rename of property * Verson 2.18.2 * fix to make hideTags work with scenario * add params to avoid null
Test with danish character ('æ', 'ø', 'å') is not found in test results.
The mapping of scenario-steps with these charaters are not mapped (eg. æ => ae)
Only danish characters are added to the SpecflowNameMapping.