Improve JSONDocumentationBuilder performance #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve JSONDocumentationBuilder performance by preparing lookups instead of using Where repeatedly. This has been tested a solution with 6000 test scenarios, with the following options: Pickles.exe -f xxx -o xxx --trfmt=nunit3 --enableComments=false -df=json -lr=xxx Before: 5.3 seconds After: 4.3 seconds Unit tests pass. The resulting json files are identical (except "GeneratedOn" datetime).
|
This is another PR for performance related to lookups. I have a few other changes with higher impact on the timing, but this one is on the same topic as #503 so I figured I would send it first. Thanks for considering this PR! |
|
Thanks again! |
|
Released in version 2.18.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve JSONDocumentationBuilder performance by preparing lookups instead of using Where repeatedly.
This has been tested on a solution with 6000 test scenarios, with the following options:
Pickles.exe -f xxx -o xxx --trfmt=nunit3 --enableComments=false -df=json -lr=xxx
Before: 5.3 seconds
After: 4.3 seconds
Unit tests pass.
The resulting json files are identical (except "GeneratedOn" datetime).