Improve FeatureParser performance #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve FeatureParser performance by caching CultureAwareDialectProvider and LanguageServices. Profiling shows that creating the CultureAwareDialectProvider and LanguageServices objects is quite costly. FeatureParser is creating them repeatedly. In this commit, these objects are cached in dictionaries. This has been tested on a solution with 6000 test scenarios, with the following options: Pickles.exe -f xxx -o xxx --trfmt=nunit3 --enableComments=false -df=json -lr=xxx Before: 4.3 seconds After: 2.0 seconds Unit tests pass. The resulting json files are identical (except "GeneratedOn" datetime).
|
So after this PR is merged (if it is merged), we went down from 15 seconds to 2 seconds for a 6000-scenarios solution. The remaining time is dominated by the Json serialization and the Gherkin parsing. There is room for improvement on the Json serialization side: it involves defining the structure before-hand instead of letting Json.net figure it out by reflection. I'm not sure it's worth it though. Thanks for considering this PR ! And thanks again for pickles 😄 ! |
|
Thanks again! I hope to be able to release a new version on thursday evening (central european time) |
|
Released in version 2.18.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve FeatureParser performance by caching CultureAwareDialectProvider and LanguageServices.
Profiling shows that creating the CultureAwareDialectProvider and LanguageServices objects is quite costly.
FeatureParser is creating them repeatedly. In this commit, these objects are cached in dictionaries.
This has been tested on a solution with 6000 test scenarios, with the following options:
Pickles.exe -f xxx -o xxx --trfmt=nunit3 --enableComments=false -df=json -lr=xxx
Before: 4.3 seconds
After: 2.0 seconds
Unit tests pass.
The resulting json files are identical (except "GeneratedOn" datetime).