Pickles GUI: Generate equivalent PowerShell or Windows Console command line #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicmonty
force-pushed
the
PowerShellCommand
branch
from
64c2f15
to
07e66ef
Compare
magicmonty
changed the title
dirkrombauts
requested changes
Oct 7, 2018
There was a problem hiding this comment.
Hi,
Thank you for this very solid pull request! With unit tests and all, that's how I like them! I have a few comments (two cosmetic, one big one) - I wrote those comments at the corresponding place in the code.
Apart from that, it looks really good and I'll be happy to merge it when you address my remarks!
src/Pickles/Pickles.UserInterface.UnitTests/CommandGeneration/WhenGeneratingCLICommands.cs
Outdated
Show resolved
Hide resolved
...ickles/Pickles.UserInterface.UnitTests/CommandGeneration/WhenGeneratingPowerShellCommands.cs
Outdated
Show resolved
Hide resolved
|
@dirkrombauts Should I rebase and squash too? |
|
Rebasing would be cool. No need to squash. |
dirkrombauts
approved these changes
Oct 8, 2018
magicmonty
force-pushed
the
PowerShellCommand
branch
from
b6bf25b
to
a634b99
Compare
|
Ok, rebased |
|
Thank you for your contribution! |
|
Released in version 2.20.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix #90
It adds two buttons, which generate the respective commands, put them into the clipboard and show a message box with the generated commands.
For each document output type, a single command line will be generated