Added PICMI_ParticleBoundaryScrapingDiagnostic class #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshapoval
changed the title
…s and removed unrelevant parameters.
dpgrote
reviewed
Aug 12, 2024
PICMI_Python/diagnostics.py
Outdated
|
|
||
| class PICMI_ParticleBoundaryScrapingDiagnostic(_ClassWithInit) : | ||
| """ | ||
| Defines the particle diagnostics that are absorbed at the boundaries, throughout the simulation. |
There was a problem hiding this comment.
Here's a suggested edit of this documentation
Defines the particle diagnostics that are used to collect the particles that are absorbed at the boundaries, throughout the simulation.
dpgrote
reviewed
Aug 12, 2024
PICMI_Python/diagnostics.py
Outdated
| @@ -329,3 +329,48 @@ def __init__(self, grid, num_snapshots, dt_snapshots, data_list=None, | |||
| self.name = name | |||
|
|
|||
| self.handle_init(kw) | |||
|
|
|||
| class PICMI_ParticleBoundaryScrapingDiagnostic(_ClassWithInit) : | |||
There was a problem hiding this comment.
A better place for this class would be right after PICMI_ParticleDiagnostic (before the Lab frame diagnostics diagnostics comment).
…aryScrapingDiagnostic class.
dpgrote
reviewed
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
PICMI_ParticleBoundaryScrapingDiagnosticclass forScrapingBoundarydiagnostics support.