Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rabbitmq_policy variable changes #3

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

rabbitmq_policy variable changes #3

wants to merge 5 commits into from

Conversation

tedgin
Copy link
Contributor

@tedgin tedgin commented Oct 19, 2015

The state field of the rabbitmq_policy variable was fixed so that it ot relies on the corresponding field in a rabbitmq_policies entry.

The pattern, priority, and tags fields have been brought in line with the documentation.

priority: "{{ item.priority | default(1) }}"
state: "{{ item.tags | default('present') }}"
tags: "{{ item.tags | default('') }}"
pattern: "{{ item.pattern }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should always be a default value.

@tedgin
Copy link
Contributor Author

tedgin commented Oct 22, 2015

Would you mind stating this in your documentation then? At the moment, the README implies that the objects in the rabbitmq_policies behave the same as the rabbitmq_policy module. The module requires a pattern field and a tags field to be provided, while your code allows defaults to be used.

martbhell and others added 2 commits November 17, 2015 09:16
 - before it used the user field to set the password on the user
EL7 to meta file and fix password setting
@jtyr
Copy link
Contributor

jtyr commented Dec 21, 2015

Thanks for the patch. Please could you submit it again to this repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants