Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on ios. #43

Merged
merged 1 commit into from
Nov 27, 2022
Merged

Fix crash on ios. #43

merged 1 commit into from
Nov 27, 2022

Conversation

dvc94ch
Copy link
Contributor

@dvc94ch dvc94ch commented Nov 20, 2022

not sure why exactly failure::Error::from() caused some crash on ios, but since failure has been deprecated for a while updated to thiserror.

@dvc94ch
Copy link
Contributor Author

dvc94ch commented Nov 21, 2022

ah realized that the place where the crash originated is not even visible in the PR. the crash happened on this line, when failure::Error::from was called. since I'm writing an ios app on a linux machine, the debugging experience is a bit poor so I can't tell you exactly what happened.

@dvc94ch
Copy link
Contributor Author

dvc94ch commented Nov 21, 2022

but here is a screenshot of a qrcode scanned with bardecoder on ios

@piderman314
Copy link
Owner

Thanks for looking into this. I'm on holiday at the moment so I'll have another look later this week and see if this can be merged and released.

@piderman314
Copy link
Owner

Hey, I had a look and it turns out you forgot to replace a use failure::Error; in image_tests.rs. Can you please fix that? I also updated master with a Github Actions build file and some clippy fixes so please merge that into your branch before continuing.

@piderman314 piderman314 merged commit ce90d04 into piderman314:master Nov 27, 2022
@dvc94ch dvc94ch deleted the fix-ios-crash branch November 27, 2022 15:10
@piderman314
Copy link
Owner

Alright, thanks for the PR. I have merged it and published a 0.4.0 version to crates.io .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants