new Buffer() is deprecated, use Buffer.from() #91

dludwig · 2020-02-24T21:57:27Z

DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
at showFlaggedDeprecation (buffer.js:159:11)
at new Buffer (buffer.js:174:3)
at Object. ({redacted}/node_modules/lz4/lib/static.js:9:30)

thanks

ankon · 2020-06-21T12:59:42Z

Having this call isn't just "annoying", but actually costs speed: NodeJS will check for each buffer constructor call whether it possibly needs to log this warning, and these checks appear in profiles in our application.

* Use Buffer.alloc/Buffer.from instead of "new Buffer" * Remove the 'noAssert' parameter from the write calls This got removed with nodejs/node#18395 Fixes pierrec#91

* Use Buffer.alloc/Buffer.from instead of "new Buffer" * Remove the 'noAssert' parameter from the write calls This got removed with nodejs/node#18395 Fixes #91

ankon added a commit to ankon/node-lz4 that referenced this issue Jun 21, 2020

Update the Buffer APIs

c601dd2

* Use Buffer.alloc/Buffer.from instead of "new Buffer" * Remove the 'noAssert' parameter from the write calls This got removed with nodejs/node#18395 Fixes pierrec#91

ankon added a commit to ankon/node-lz4 that referenced this issue Jun 21, 2020

Update the Buffer APIs

15de73d

* Use Buffer.alloc/Buffer.from instead of "new Buffer" * Remove the 'noAssert' parameter from the write calls This got removed with nodejs/node#18395 Fixes pierrec#91

ankon mentioned this issue Jun 21, 2020

Update the Buffer APIs #98

Merged

pierrec closed this as completed in #98 Jun 22, 2020

pierrec pushed a commit that referenced this issue Jun 22, 2020

Update the Buffer APIs (#98)

76f347f

* Use Buffer.alloc/Buffer.from instead of "new Buffer" * Remove the 'noAssert' parameter from the write calls This got removed with nodejs/node#18395 Fixes #91

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new Buffer() is deprecated, use Buffer.from() #91

new Buffer() is deprecated, use Buffer.from() #91

dludwig commented Feb 24, 2020

ankon commented Jun 21, 2020

new Buffer() is deprecated, use Buffer.from() #91

new Buffer() is deprecated, use Buffer.from() #91

Comments

dludwig commented Feb 24, 2020

ankon commented Jun 21, 2020