Added simultaneous support of jest v26 & v27 for transformer #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for making it solid and compatible, @cbmd. Could you take a look at the build results? |
rtrembecky
reviewed
Aug 12, 2021
src/jestTransformer.ts
Outdated
Comment on lines
28
to
30
| input, | ||
| filePath, | ||
| __compatJestConfig, |
There was a problem hiding this comment.
jest and babel-jest use arg names of (sourceText, sourcePath, options) for both process and getCacheKey, it would be cool to get aligned with them: https://jestjs.io/docs/next/code-transformation#writing-custom-transformers
# Conflicts: # package.json # yarn.lock
|
Sure, i'll take a look next week @piglovesyou! |
… definitely bumped to v27
# Conflicts: # yarn.lock
|
@piglovesyou it's ready to re-review. |
piglovesyou
requested changes
Aug 30, 2021
There was a problem hiding this comment.
So nice. Thank you @cbmd!!
I left one comment. Could you consider and share what you think about it?
|
@piglovesyou can this one be released to npm? :) |
|
I'll do it soon! Sorry, I've forgotten it after my tasks.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.