-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow passing schema plugins #618
base: main
Are you sure you want to change the base?
allow passing schema plugins #618
Conversation
Great. Could you make the build pass? My quick search finds this - Error: Unable to find template plugin matching typescript-urql-graphcache |
Sure, I'll fix the remaining tests 👍 |
7c20948
to
330eb82
Compare
330eb82
to
6a85e0b
Compare
@piglovesyou I've now updated the snapshots. is there something needed besides updated snapshots? I added a mention about the schemaPlugins to the readme. It's a bit funny example since it has both urql and apollo, but I think the idea is the most important idea there. |
af67746
to
88e9c52
Compare
I would also consider getting rid of this since schemaPlugins allows controlling optional plugins from the outside: graphql-let/src/lib/codegen.ts Lines 16 to 27 in 88e9c52
and possibly the default |
Sounds so makes sense. Let's remove |
Got rid of |
Enables passing plugins that work in similar manner to
typescript
and need to be generated in a single file.Fixes: #617
Let me know if this is something you'd consider merging and I can work on tests etc. I'm not sure if
schemaPlugin
is a correct term in this case, but that seemed to be already used in the codebase.