Update to jest 28 #635
Open
Update to jest 28 #635
+1,048
−1,136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not needed to solve the original problem, but I leave it here in case it's of use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #634.
Internally, graphql-let just imports create transformer from jest. So updating its own copy of Jest should solve this issue. As mentioned in the upstream PR (jestjs/jest#12638), it seems like this is a more restrictive return type than was previously allowed, but it was a subset of the previous return type, so my assumption is that this should be backwards compatible.
Regardless, it's needed, but would be prudent to test against an older project to verify if this is a major or minor release (and see if there's a way to note this with jest optional deps or something)