Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't add empty realizations to main module files #78

Merged
merged 3 commits into from
Feb 1, 2024
Merged

don't add empty realizations to main module files #78

merged 3 commits into from
Feb 1, 2024

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Nov 23, 2023

  • if a realization is deleted in the repo, often the input folder remains in the clones, containing the input files that are not version-controlled
  • update_modules_embedding then adds that empty realization to module.gms, but warns it cannot be used
  • After this PR: Warn that it cannot be used, and therefore don't add it to module.gms
  • added a small test that let me find several errors:
    • modelpath was not used consistently, often assuming .
    • if the first line of main.gms contains an include, the script ran infinitely

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a604ba) 35.63% compared to head (bf38bab) 41.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   35.63%   41.34%   +5.70%     
==========================================
  Files          51       51              
  Lines        1664     1669       +5     
==========================================
+ Hits          593      690      +97     
+ Misses       1071      979      -92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orichters
Copy link
Contributor Author

@tscheypidi: This has been lingering around since two month now, do you wanna have a look?

Copy link
Member

@tscheypidi tscheypidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orichters sorry for having looked at it earlier and thanks for the reminder. This one somehow slipped through my to-do-list. Changes look good, you just have to fix the merge conflicts.

@orichters
Copy link
Contributor Author

@orichters sorry for having looked at it earlier and thanks for the reminder. This one somehow slipped through my to-do-list. Changes look good, you just have to fix the merge conflicts.

All good, wasn't urgent at all.

@orichters orichters merged commit 4c89b71 into pik-piam:master Feb 1, 2024
4 checks passed
@orichters orichters deleted the updatemodules branch February 20, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants