Refactor manipulateConfig #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfuehrlich-pik
approved these changes
Oct 13, 2022
| for (key in names(arguments)) { | ||
| value <- arguments[[key]] | ||
| if (length(value) > 1) { | ||
| value <- capture.output(cat(paste0(value, ", "), fill = maxchar)) |
There was a problem hiding this comment.
Ah the classic capture.output cat 😂 There has to be a cleaner way to get padding, but this does not seem important enough to fix.
| # definitions in the form | ||
| # > $setglobal key value | ||
| manipulations[[paste0(key, "_pattern1")]][1] <- paste0( | ||
| "((\\n|^)[\\t ]*\\$[sS][eE][tT][gG][lL][oO][bB][aA][lL][\\t ]*", key, "[\\t ]).*?( *!!|\\n|$)") |
There was a problem hiding this comment.
Is this the longest regex in our codebase? I really hope so 😬
There was a problem hiding this comment.
well, certainly not the worst, the one 4 lines down is much worse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I didn't manage to solve the real bug #121 , I refactored manipulateConfig in the process (lightly) and it is now linter warning free.