added option to write units in netCDF files based on comment argument #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tscheypidi
requested changes
Sep 27, 2021
There was a problem hiding this comment.
Interpreting the "comment" section of a magclass object as unit will often lead to errors. What you could do instead is a) introduce a "unit" argument in the function call to specify the unit, or b) use the madrat-based naming conventions that comment lines containing the unit start with "unit: " and only use that part as unit (if existing). The comment could then look for instance like: comment <- "unit: m^3" and unit would be m^3. Important for this implementation would be that also other comment lines would be allowed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.