Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: End use share calculation #40

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Bugfix: End use share calculation #40

wants to merge 4 commits into from
+124 −180

Conversation

robinhasse
Copy link
Contributor

@robinhasse robinhasse commented Oct 11, 2024 •
edited
Loading

  • Fix end use share calculation
    • correct normalisation of shares
    • switch from linear to exponential extrapolation of end use changes to ensure strictly positive values
    • correct time reference in extrapolation (we no directly calculate yearly values instead of the 2000 value that had inconsistent time references)
  • Bug fix in the combination of Odyssee data and disaggregated IEA data
  • Removed correction of space cool in region Africa as the disaggregation delivers acceptable values with the corrections
  • read GDP in 2005$ explicitly (will switch to more recent soon)
  • Bugfix: missing default suptype for TCEP caused error

hagento
hagento reviewed Oct 14, 2024
View reviewed changes
R/calcFEbyEUEC.R Outdated Show resolved Hide resolved
hagento
hagento reviewed Oct 14, 2024
View reviewed changes
R/calcShares.R Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice idea with outsourcing the end-use share interpolation into an extra function. Looks like your implementation also prevents negative shares from the interpolation and we can finally give up the hard-code correction 👍

hagento
hagento approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@hagento hagento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bug-fixing and rework of the tedious function that is calcShares. I have nothing more to add from my side 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hagento hagento hagento approved these changes

@ricardarosemann ricardarosemann Awaiting requested review from ricardarosemann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robinhasse @hagento