Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare scenarios #3

Merged
merged 4 commits into from
May 8, 2024
Merged

Conversation

robinhasse
Copy link
Collaborator

  • I add an initial set of compare scenarios scripts. Until now, only few stock and flow variables are plotted.
  • You can now pass a file path to a custom reporting template. If there is now file, it is expected that you refer to a internal mapping as before.
  • I improve the messages and errors thrown when variables are missing that reportAgg expects. Before, there was a unmeaning madrat error given when you tried to aggregate an empty madrat object. This happens, if you try to report a missing set element explicitly. Now, this leads to NULL being reported.
  • You can now pass a file path to a custom reporting template. If there is now file, it is expected that you refer to a internal mapping as before.

Copy link
Contributor

@ricardarosemann ricardarosemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, especially also for the additional warnings, probably very helpful.
I only found one point that I'd like to be clarified, otherwise it's all looking good.

inst/compareScenarios/cs_01_stocks_flows.Rmd Show resolved Hide resolved
@robinhasse robinhasse merged commit 527ed6e into pik-piam:main May 8, 2024
2 checks passed
@robinhasse robinhasse deleted the compareScenarios branch May 8, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants