adapt to refactored sodym visualization and data writing #10
Conversation
| from sodym.export.data_writer import DataWriter | ||
| from sodym.export.helper import ArrayPlotter | ||
| from sodym.export.data_writer import export_mfa_flows_to_csv, export_mfa_stocks_to_csv, export_mfa_to_pickle | ||
| from sodym.export.array_plotter import PlotlyArrayPlotter |
There was a problem hiding this comment.
We could think about adding an __init__.py file to the sodym/export directory, to simplify these imports, so that we could do from sodym.export import PlotlyArrayPlotter, SankeyArrayPlotter. I did this on the sodym directory level, but tbh, it would be good check everything is there that we want to be there. And clearly this is not a necessary thing, but can make the imports look a bit nicer (and has the advantage that users do not need to know the file names within the sodym/export module).
|
Btw, I thought some of the steel data was propriety, and this is why it has not been added to git? I don't have that data locally either, so I have never been able to run the steel model. Not sure how you would feel about making the package private and adding the data to git? Scientific reproducibility anyway goes out the window if the data is not accessible. I'm not sure I really want to make the code inaccessible either, but maybe it's worth considering to ease our development. |
Plastics is tested, steel fails due to missing data in the data repo. Please update @Merjo!