-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kraken
: balance <-> position disparities with crypto/crypto pairs
#373
Labels
accounting
prolly positioning: the accounting of "what/when (is) owned"
broker-backend
`brokerd`/`datad` related backend tech
bug
guille broke it prolly
clearing
auction and mm tech: EMS, OMS, algo-trading
Comments
goodboy
added
bug
guille broke it prolly
clearing
auction and mm tech: EMS, OMS, algo-trading
broker-backend
`brokerd`/`datad` related backend tech
labels
Aug 5, 2022
I got something similar due to a couple different issues, so here is a (partial) follow up TODO list:
[kraken.spot."xrpeur.kraken"]
size = 78.31125778
ppu = 0.3222278400000044
bsuid = "xrpeur"
clears = [
{ dt = "2022-12-21T07:20:16.316061+00:00", ppu = 0.3222278400000044, accum_size = 778.33125778, price = 0.3212, size = 778.33125778, cost = 0.4, tid = "TJKLRL-7UE2L-BX2UE5" },
{ dt = "2022-12-21T07:26:56+00:00", ppu = 0.3222278400000044, accum_size = 78.31125778, price = "NaN", size = -700.02, cost = 0, tid = "1503A92E24BAA1E8B8E7B78E79A78AAF3E6C3F3E35227EF7D2C13754876B37D5" },
]
|
goodboy
added a commit
that referenced
this issue
Jan 13, 2023
See more details in the GH comment: #373 (comment) More or less we need to pull and include the transfer fees for withdrawals in our ledger tracking but this serves as a sloppy workaround for the moment.
goodboy
added a commit
that referenced
this issue
Jan 13, 2023
Likely pertains to helping with stuff in issues #345 and #373 and just generally is handy to have when processing ledgers / clearing event tables. Adds the following helper methods: - `iter_by_dt()` to iter-sort an arbitrary `Transaction`-like table of clear entries. - `Position.iter_clears()` as a convenience wrapper for the above.
goodboy
added a commit
that referenced
this issue
Jan 13, 2023
Likely pertains to helping with stuff in issues #345 and #373 and just generally is handy to have when processing ledgers / clearing event tables. Adds the following helper methods: - `iter_by_dt()` to iter-sort an arbitrary `Transaction`-like table of clear entries. - `Position.iter_clears()` as a convenience wrapper for the above.
goodboy
added a commit
that referenced
this issue
Jan 13, 2023
See more details in the GH comment: #373 (comment) More or less we need to pull and include the transfer fees for withdrawals in our ledger tracking but this serves as a sloppy workaround for the moment.
goodboy
added a commit
that referenced
this issue
Jan 13, 2023
Likely pertains to helping with stuff in issues #345 and #373 and just generally is handy to have when processing ledgers / clearing event tables. Adds the following helper methods: - `iter_by_dt()` to iter-sort an arbitrary `Transaction`-like table of clear entries. - `Position.iter_clears()` as a convenience wrapper for the above.
ergg, found another after a recent xrp transfer.. Traceback (most recent call last):
File "/home/goodboy/repos/tractor/tractor/_runtime.py", line 196, in _invoke
res = await coro
File "/home/goodboy/repos/piker/piker/brokers/kraken/broker.py", line 609, in trades_dialogue
raise ValueError(
ValueError: Could not reproduce balance:
dst: xrp, 7.78e-06 |
goodboy
added a commit
that referenced
this issue
Jan 30, 2023
Likely pertains to helping with stuff in issues #345 and #373 and just generally is handy to have when processing ledgers / clearing event tables. Adds the following helper methods: - `iter_by_dt()` to iter-sort an arbitrary `Transaction`-like table of clear entries. - `Position.iter_clears()` as a convenience wrapper for the above.
goodboy
added a commit
that referenced
this issue
Jan 31, 2023
Likely pertains to helping with stuff in issues #345 and #373 and just generally is handy to have when processing ledgers / clearing event tables. Adds the following helper methods: - `iter_by_dt()` to iter-sort an arbitrary `Transaction`-like table of clear entries. - `Position.iter_clears()` as a convenience wrapper for the above.
goodboy
added
the
accounting
prolly positioning: the accounting of "what/when (is) owned"
label
Mar 2, 2023
51 tasks
30 tasks
Closed in favor of #515 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accounting
prolly positioning: the accounting of "what/when (is) owned"
broker-backend
`brokerd`/`datad` related backend tech
bug
guille broke it prolly
clearing
auction and mm tech: EMS, OMS, algo-trading
Discovered by @iamzoltan and not surprising since i never tested any of this in the development of #349.
The plan is to land that PR despite this issue (since master has a half working / bug filled order mode for
kraken
right now) and resolve this in post mortem fixes.issue descr
More or less there seems to be the
ValueError
raised from the pp validation logic section oftrades_dialogue()
but reproducing this requires a ledger with the appropriate intercrypto pair transactions.Solutions/TODO:
trades_kraken_spot.toml
fileClient.get_balances()
which can be hard coded manually in the code for testingtraceback
The text was updated successfully, but these errors were encountered: