Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: if prscd can not connect to zipper when creating, do not cache it #6

Merged
merged 2 commits into from
Jan 12, 2024
Merged

fix: if prscd can not connect to zipper when creating, do not cache it #6

merged 2 commits into from
Jan 12, 2024

Conversation

fanweixiao
Copy link
Member

This is not the best solution, but makes service way better, at least prscd will try to reconnect zipper next time.

@fanweixiao fanweixiao self-assigned this Jan 11, 2024
@woorui
Copy link
Collaborator

woorui commented Jan 12, 2024

Use yomo.WithSourceReConnect() and yomo.WithSfnReConnect() to make it continuously connect until it succeeds.

image

@fanweixiao
Copy link
Member Author

@woorui updated, please review.

@fanweixiao fanweixiao merged commit c545eb5 into main Jan 12, 2024
@fanweixiao fanweixiao deleted the fix/zipper-conn branch January 12, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woorui woorui woorui approved these changes

@venjiang venjiang Awaiting requested review from venjiang

Assignees

@fanweixiao fanweixiao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fanweixiao @woorui