Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the crumb still required? #73

Open
smeijer opened this issue Aug 12, 2020 · 4 comments
Open

Is the crumb still required? #73

smeijer opened this issue Aug 12, 2020 · 4 comments

Comments

@smeijer
Copy link

smeijer commented Aug 12, 2020

I've been trying a lot of different URLs without providing a crumb, and they all seem to work without it. So I'm curious, is the crumb still required? Or is it something left from an old API version?

For example,

The search API, works without crumb:

curl -s "https://query1.finance.yahoo.com/v1/finance/search?q=AAPL&quotesCount=6&newsCount=0&enableFuzzyQuery=0"

The download/symbol api, works without crumb:

curl -s "https://query1.finance.yahoo.com/v7/finance/download/AAPL?period1=946681200&period2=1597134159&interval=1d&events=history"

And the quotes API, works without crumb:

curl -s "https://query1.finance.yahoo.com/v10/finance/quoteSummary/AAPL?modules=price&formatted=false"

What am I missing here?

// cc: @gadicc

@gadicc
Copy link
Collaborator

gadicc commented Aug 12, 2020 via email

@MichaelDeBoey
Copy link

@gadicc Did you already got the time to take a look at this please? 🤔

@gadicc
Copy link
Collaborator

gadicc commented Aug 29, 2020

Hey @MichaelDeBoey thanks for the nudge. Unfortunately something's up with my test setup, so it might take me a little while longer to get started on this. But in any case, I imagine that we'd first have a release where not using the crumb is optional, before making that a default behaviour. And at least now, although there's a bit of unnecessary extra data being sent, everything is still working great.

@MichaelDeBoey
Copy link

Don't worry, no pressure 🙂
Just wanted to give you a heads up 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants