Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collections broken when used with user-supplied password #101

Closed
0-wiz-0 opened this issue Aug 18, 2014 · 8 comments · Fixed by #107
Closed

collections broken when used with user-supplied password #101

0-wiz-0 opened this issue Aug 18, 2014 · 8 comments · Fixed by #107

Comments

@0-wiz-0
Copy link
Contributor

0-wiz-0 commented Aug 18, 2014

In a working config without password, I changed from one collection to many, i.e.:

collections = alt

became

collections = alt,kurse,jahrestage,privat 

This doesn't work. It asks for 4 passwords at once and errors out:

Server password for user at the resource https://example.com/caldav.php/user/kurse: Server password for user at the resource https://example.com/caldav.php/user/alt: Server password for user at the resource https://example.com/caldav.php/user/privat: Server password for user at the resource https://example.com/caldav.php/user/jahrestage: 
Save this password in the keyring? [y/N]: 
Traceback (most recent call last):
  File "/usr/pkg/lib/python2.7/site-packages/vdirsyncer/cli.py", line 136, in storage_instance_from_config
    return cls(**config)
  File "/usr/pkg/lib/python2.7/site-packages/vdirsyncer/storage/dav.py", line 492, in __init__
    super(CaldavStorage, self).__init__(**kwargs)
  File "/usr/pkg/lib/python2.7/site-packages/vdirsyncer/storage/dav.py", line 287, in __init__
    useragent, dav_header=self.dav_header)
  File "/usr/pkg/lib/python2.7/site-packages/vdirsyncer/storage/dav.py", line 196, in __init__
    password = utils.get_password(username, url)
  File "/usr/pkg/lib/python2.7/site-packages/vdirsyncer/utils/__init__.py", line 126, in get_password
    click.confirm('Save this password in the keyring?', default=False):
  File "/usr/pkg/lib/python2.7/site-packages/click/termui.py", line 122, in confirm
    raise Abort()
Abort
critical: error: Failed to initialize kurse from user_caldav_calendar

This works fine when putting the password in the configuration file though.

@0-wiz-0 0-wiz-0 changed the title collections broken collections broken when used with user-supplied password Aug 18, 2014
@untitaker
Copy link
Member

The underlying problem is one i'd like to get solved upstream in click, or a separate package extending click. It'll take quite a while, for now all i can advise is to avoid password prompting, sorry.

@untitaker untitaker added the bug label Aug 18, 2014
untitaker added a commit that referenced this issue Aug 19, 2014
@untitaker
Copy link
Member

The problem with overlapping prompts has been fixed. It still asks for the password multiple times, but i am not sure how to fix that without introducing global state.

@untitaker
Copy link
Member

Regarding ^C, i've been told to literally "give up" on fixing that issue by the #python channel on Freenode.

Everything else should work though:

  • No overlapping prompts
  • No prompting passwords more than once for each hostname.

@geier
Copy link
Member

geier commented Aug 23, 2014

in offlineimap ^C doesn't work most of the time either...

Quoting Markus Unterwaditzer (2014-08-23 10:39:57)

Regarding ^C, i've been told to literally "give up" on fixing that issue by the #python channel on Freenode.

Everything else should work though:

  • No overlapping prompts
  • No prompting passwords more than once for each hostname.

Reply to this email directly or view it on GitHub:
#101 (comment)

@untitaker
Copy link
Member

And the same with beets.

@untitaker
Copy link
Member

0.2.5 is out.

@0-wiz-0
Copy link
Contributor Author

0-wiz-0 commented Aug 27, 2014

pkgsrc updated to 0.2.5, thanks for letting me know!

@untitaker
Copy link
Member

You could use https://github.com/untitaker/vdirsyncer/tags.atom for this.

jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Aug 28, 2014
Version 0.2.5
=============

*released on 27 August 2014*

- Don't ask for the password of one server more than once and fix multiple
  concurrency issues, see issue `#101`_.

- Better validation of DAV endpoints.

.. _`#101`: pimutils/vdirsyncer#101
jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Oct 11, 2014
Version 0.2.5
=============

*released on 27 August 2014*

- Don't ask for the password of one server more than once and fix multiple
  concurrency issues, see issue `#101`_.

- Better validation of DAV endpoints.

.. _`#101`: pimutils/vdirsyncer#101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants