add some blacklist code to allow exclude collections from syncronization #184 #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
WhyNotHugo
reviewed
Jan 12, 2023
| @@ -87,9 +88,14 @@ def _validate_collections_param(collections): | |||
| if collection_name in collection_names: | |||
| raise ValueError("Duplicate value.") | |||
| collection_names.add(collection_name) | |||
There was a problem hiding this comment.
If a name starts with !, you're also adding it to the collection_names list here. You probably want to move this line to an else block after if collection[0] == "!":.
There was a problem hiding this comment.
Yes I saw that, but does it matter at this point, as collection_names is temporary here and as I understand only used to weed out duplicate values from the collections list. When I leave the excludes within the collection_names I don't have to bother further with that. Or did I missed something there and collection_names is used for anything else?
I replaced blacklist with excludes, comes in the next push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this isn't to crude as I didn't had much time to dive to deep into the code.