Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 4.2 and fix tests #370

Merged
merged 12 commits into from
Sep 6, 2023
Merged

Django 4.2 and fix tests #370

merged 12 commits into from
Sep 6, 2023

Conversation

blag
Copy link
Collaborator

@blag blag commented Sep 6, 2023

Closes #354, but also does more.

Supercedes #369.

This PR is prep for a release. I'd like to get CI passing before I submit a PR to bump the version as part of a release.

Changes proposed in this PR:

  • Move accounts/tests to ./tests (so we don't distribute tests with package)
  • Use timezone-aware now() in middleware
  • Fix tests
  • Use ruff
  • Drop Django 2.2, and Python 3.6 and 3.7
  • Update GHA config

Tips for an ideal PR

@blag
Copy link
Collaborator Author

blag commented Sep 6, 2023

Okay, I think I figured out DeepSource. This is ready for review. I'll merge it once I get a signoff. 😄

Copy link
Collaborator

@uhurusurfa uhurusurfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 looks good

@uhurusurfa uhurusurfa merged commit e6a1f0c into master Sep 6, 2023
9 checks passed
@blag blag deleted the django-4.2-and-fix-tests branch September 8, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: can't compare offset-naive and offset-aware datetimes While cheching account is expred
2 participants