New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] working comments drf api #30

Open

rosscdh wants to merge 3 commits into pinax:master from rosscdh:feature/drf-integration

rosscdh commented Jun 27, 2020

LACKS TESTS.. this is WIP and an attempt to open a discussion on the topic

Changes proposed in this PR:

integrate basic drf functionality urls and viewsets for comments via api
integrate openapi specs

Tips for an ideal PR

You have read our Code of Conduct: https://github.com/pinax/.github/blob/master/CODE_OF_CONDUCT.md
You have read our Contributing info: https://github.com/pinax/.github/blob/master/CONTRIBUTING.md
The PR is atomic
Unit tests have been updated/added, if needed
App version number has been updated in setup.py (Pinax uses SemVer)
Change Log has been updated

stard0g added 3 commits

June 27, 2020 20:01


          working comments

c307658


          schema name

935ac1e


          create ep serializer

KatherineMichel mentioned this pull request

Is it suitable with a DRF project? pinax/pinax-referrals#54

Open

Member

KatherineMichel commented Jul 19, 2020

Thank you for the PR and for opening a discussion... see my comments on: pinax/pinax-referrals#54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet