Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebhookRegistry.unregister #411

Closed
blueyed opened this issue Oct 16, 2017 · 2 comments · Fixed by #620
Closed

Add WebhookRegistry.unregister #411

blueyed opened this issue Oct 16, 2017 · 2 comments · Fixed by #620
Milestone

Comments

@blueyed
Copy link
Contributor

blueyed commented Oct 16, 2017

There is no public API to unregister a webhook, but only to override an existing one (by registering another one with the same name).

Do you think it makes sense to have an API for that, e.g. when you do not want to handle certain events?

@paltman paltman added this to the Samwise milestone Oct 20, 2017
@paltman
Copy link
Member

paltman commented Oct 20, 2017

I like this idea.

@paltman paltman closed this as completed Oct 20, 2017
@paltman paltman removed this from the Samwise milestone Oct 20, 2017
@paltman paltman reopened this Oct 20, 2017
@paltman
Copy link
Member

paltman commented Oct 20, 2017

Reopened, retitled, and removed from Samwise, to reflect it's something we should do.

@paltman paltman changed the title Add WebhookRegistry.unregister? Add WebhookRegistry.unregister Oct 20, 2017
@paltman paltman added this to the Rosie milestone Oct 25, 2017
@paltman paltman modified the milestones: Rosie, December 2017 Sprint Dec 1, 2017
@paltman paltman modified the milestones: December 2017 Sprint, Light Nov 25, 2021
paltman added a commit that referenced this issue Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants