-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[repo] protected branch: remove requirement for PRs to be up to date with master #415
Comments
CircleCI does not test the merge commit after all currently.. :/ See https://discuss.circleci.com/t/show-test-results-for-prospective-merge-of-a-github-pr/1662/ |
@paltman |
I believe this is complete. |
Well, at least the |
I think the "Update branch" button indicates that the branch has to be up-to-date with master still? Otherwise there is #422 (in a separate issue). |
#422 is merged. Can this be closed? |
The main issue is still there:
|
Are you talking about the "update branch" on Github PRs? I'm confused. |
Oh, I see now. I mostly override it if there are no conflicts. Why does it really matter one way or another? |
Also, in my experience, CircleCI is, in fact, rerunning after I update the branch from master. |
@paltman
It makes sense when transitioning to a new build system, but by now I think you should rather update all older PRs, and then we can disable it - in the end it only requires to update all PRs once one has been merged.
The text was updated successfully, but these errors were encountered: