Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account: add publishable_key field #441

Merged
merged 5 commits into from
Oct 30, 2017
Merged

Account: add publishable_key field #441

merged 5 commits into from
Oct 30, 2017

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Oct 24, 2017

Fixes #437.

@codecov
Copy link

codecov bot commented Oct 24, 2017 •
edited
Loading

Codecov Report

Merging #441 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #441      +/-   ##
==========================================
+ Coverage   99.39%   99.39%   +<.01%     
==========================================
  Files          34       34              
  Lines        1662     1663       +1     
  Branches      135      135              
==========================================
+ Hits         1652     1653       +1     
  Misses          5        5              
  Partials        5        5
Flag Coverage Δ
#py27dj110 99.39% <100%> (ø) ⬆️
#py27dj111 99.39% <100%> (ø) ⬆️
#py27dj18 99.39% <100%> (ø) ⬆️
#py34dj110 99.39% <100%> (ø) ⬆️
#py34dj111 99.39% <100%> (ø) ⬆️
#py34dj18 99.39% <100%> (ø) ⬆️
#py34dj20 99.39% <100%> (ø) ⬆️
#py35dj110 99.39% <100%> (ø) ⬆️
#py35dj111 99.39% <100%> (ø) ⬆️
#py35dj18 99.39% <100%> (ø) ⬆️
#py35dj20 99.39% <100%> (ø) ⬆️
#py36dj111 99.39% <100%> (ø) ⬆️
#py36dj20 99.39% <100%> (ø) ⬆️
Impacted Files Coverage Δ
pinax/stripe/models.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a1f3b8...a5819aa. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 24, 2017

Codecov Report

Merging #441 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #441      +/-   ##
==========================================
+ Coverage   99.39%   99.39%   +<.01%     
==========================================
  Files          34       34              
  Lines        1662     1663       +1     
  Branches      135      135              
==========================================
+ Hits         1652     1653       +1     
  Misses          5        5              
  Partials        5        5
Flag Coverage Δ
#py27dj110 99.39% <100%> (ø) ⬆️
#py27dj111 99.39% <100%> (ø) ⬆️
#py27dj18 99.39% <100%> (ø) ⬆️
#py34dj110 99.39% <100%> (ø) ⬆️
#py34dj111 99.39% <100%> (ø) ⬆️
#py34dj18 99.39% <100%> (ø) ⬆️
#py34dj20 99.39% <100%> (ø) ⬆️
#py35dj110 99.39% <100%> (ø) ⬆️
#py35dj111 99.39% <100%> (ø) ⬆️
#py35dj18 99.39% <100%> (ø) ⬆️
#py35dj20 99.39% <100%> (ø) ⬆️
#py36dj111 99.39% <100%> (ø) ⬆️
#py36dj20 99.39% <100%> (ø) ⬆️
Impacted Files Coverage Δ
pinax/stripe/models.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a1f3b8...a5819aa. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 24, 2017 •
edited
Loading

Codecov Report

Merging #441 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #441      +/-   ##
==========================================
+ Coverage   99.52%   99.52%   +<.01%     
==========================================
  Files          34       34              
  Lines        1688     1690       +2     
  Branches      145      145              
==========================================
+ Hits         1680     1682       +2     
  Misses          4        4              
  Partials        4        4
Flag Coverage Δ
#py27dj110 99.17% <100%> (ø) ⬆️
#py27dj111 99.17% <100%> (ø) ⬆️
#py27dj18 99.46% <100%> (ø) ⬆️
#py34dj110 99.17% <100%> (ø) ⬆️
#py34dj111 99.17% <100%> (ø) ⬆️
#py34dj18 99.46% <100%> (ø) ⬆️
#py34dj20 99.17% <100%> (ø) ⬆️
#py35dj110 99.17% <100%> (ø) ⬆️
#py35dj111 99.17% <100%> (ø) ⬆️
#py35dj18 99.46% <100%> (ø) ⬆️
#py35dj20 99.17% <100%> (ø) ⬆️
#py36dj111 99.17% <100%> (ø) ⬆️
#py36dj20 99.17% <100%> (ø) ⬆️
#py36dj20psql 99.17% <100%> (ø) ⬆️
Impacted Files Coverage Δ
pinax/stripe/models.py 100% <100%> (ø) ⬆️
pinax/stripe/actions/charges.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dacc4e...57523f3. Read the comment docs.

@blueyed
Copy link
Contributor Author

blueyed commented Oct 24, 2017

Likely not needed - the ephemeral key seems to be enough after all.

@blueyed blueyed closed this Oct 24, 2017
@blueyed blueyed deleted the account-publishable_key branch October 24, 2017 14:11
@blueyed blueyed restored the account-publishable_key branch October 25, 2017 16:32
@blueyed blueyed reopened this Oct 25, 2017
@paltman paltman added this to the Samwise milestone Oct 30, 2017
@paltman
Copy link
Member

paltman commented Oct 30, 2017

@blueyed are you able to update this branch against master and merge the migrations? If not I might punt this until the Rosie release next month. Trying to get a release buttoned up tomorrow.

@blueyed
Copy link
Contributor Author

blueyed commented Oct 30, 2017

@paltman
Updated and merged.

I would suggest waiting until the end of the week at least for the release. Otherwise it might become problematic with regard to migrations etc, in case there are changes that would need data migrations still.

@paltman
Copy link
Member

paltman commented Oct 30, 2017

What happens this week?

I have a follow-up milestone, Rosie, due at the end of November to capture any fixes after 4.0.0 (Samwise ships). There really isn't much left in this (Samwise) milestone.

@paltman paltman merged commit 229b3be into pinax:master Oct 30, 2017
@blueyed blueyed deleted the account-publishable_key branch October 30, 2017 17:23
@blueyed
Copy link
Contributor Author

blueyed commented Oct 30, 2017

What happens this week?

Tomorrow is a holiday in Germany, but then we will keep working on the integration.

We have a mix of #400 / #402 in use (#440) for example, which makes sense to include IMHO.
I think @ticosax might create a separate PR for it, once #427 is merged.
I suggest getting #440 as empty as possible before a release.

It might make sense to create a meta issue to track TODOs for the release, e.g. that migrations should be squashed (using Django's mechanism).

@blueyed
Copy link
Contributor Author

blueyed commented Oct 30, 2017

IMHO there is no reason to rush a release with Stripe Connect integration that is still very bumpy.
You might want to create some smaller bugfix release (without the Connect feature), if that makes sense?!

@paltman
Copy link
Member

paltman commented Oct 30, 2017

Fair enough. I relying on feedback from people actually using this feature in practice. I'm planning to build something with it for myself. I'm just getting nervous about how big this is becoming. I'll block any other non-connect related features until after the release. Do you want to create that issue with the TODOs and we'll add it to Samwise?

@paltman
Copy link
Member

paltman commented Oct 30, 2017

What else is in #440 besides #400 and #402?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ticosax ticosax ticosax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Samwise
Development

Successfully merging this pull request may close these issues.
3 participants
@blueyed @paltman @ticosax