test_webhook_duplicate_event: add assertion for data #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
force-pushed
the
test_webhook_duplicate_event-data
branch
from
fa2d895
to
6dfa788
Compare
Codecov Report
@@ Coverage Diff @@
## master #461 +/- ##
=========================================
- Coverage 99.4% 99.4% -0.01%
=========================================
Files 34 34
Lines 1682 1680 -2
Branches 144 144
=========================================
- Hits 1672 1670 -2
Misses 5 5
Partials 5 5
Continue to review full report at Codecov.
|
log_exception / EventProcessingException expects a string for `data`.
blueyed
force-pushed
the
test_webhook_duplicate_event-data
branch
from
6dfa788
to
ba8d8e6
Compare
paltman
approved these changes
Oct 30, 2017
paltman
reviewed
Oct 30, 2017
| @@ -195,15 +195,12 @@ class Webhook(View): | |||
| def dispatch(self, *args, **kwargs): | |||
| return super(Webhook, self).dispatch(*args, **kwargs) | |||
|
|
|||
| def extract_json(self): | |||
There was a problem hiding this comment.
I doubt anyone is subclassing Webhook and overriding extract_json but if they are this is a BIC. I think we should just document this in the release notes (I'll take care of it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.