Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python versions in README #463

Merged
merged 2 commits into from
Oct 30, 2017
Merged

Update python versions in README #463

merged 2 commits into from
Oct 30, 2017

Conversation

grahamu
Copy link
Contributor

@grahamu grahamu commented Oct 29, 2017

What's this PR do?

Update python versions in Environment Setup
Fix import sorting

Any background context you want to provide?

Update README for latest Python versions and revised testing instructions.
I'm not sure the whole CFLAGS= preamble is needed either, as I followed
the setup without that portion and tests worked fine.

Definition of Done (check if considered and/or addressed):

  • Are all backwards incompatible changes documented in this PR?
  • Have all new dependencies been documented in this PR?
  • Has the appropriate documentation been updated (if applicable)?
  • Have you written tests to prove this change works (if applicable)?

@paltman
Copy link
Member

paltman commented Oct 30, 2017

@paltman paltman added this to the Samwise milestone Oct 30, 2017
@codecov
Copy link

codecov bot commented Oct 30, 2017

Codecov Report

Merging #463 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
+ Coverage    99.4%   99.52%   +0.12%     
==========================================
  Files          34       34              
  Lines        1682     1690       +8     
  Branches      144      145       +1     
==========================================
+ Hits         1672     1682      +10     
+ Misses          5        4       -1     
+ Partials        5        4       -1
Flag Coverage Δ
#py27dj110 99.17% <ø> (-0.24%) ⬇️
#py27dj111 99.17% <ø> (-0.24%) ⬇️
#py27dj18 99.46% <ø> (+0.06%) ⬆️
#py34dj110 99.17% <ø> (-0.24%) ⬇️
#py34dj111 99.17% <ø> (-0.24%) ⬇️
#py34dj18 99.46% <ø> (+0.06%) ⬆️
#py34dj20 99.17% <ø> (-0.24%) ⬇️
#py35dj110 99.17% <ø> (-0.24%) ⬇️
#py35dj111 99.17% <ø> (-0.24%) ⬇️
#py35dj18 99.46% <ø> (+0.06%) ⬆️
#py35dj20 99.17% <ø> (-0.24%) ⬇️
#py36dj111 99.17% <ø> (-0.24%) ⬇️
#py36dj20 99.17% <ø> (-0.24%) ⬇️
#py36dj20psql 99.17% <ø> (-0.24%) ⬇️
Impacted Files Coverage Δ
pinax/stripe/actions/charges.py 100% <0%> (ø) ⬆️
pinax/stripe/actions/events.py 100% <0%> (ø) ⬆️
pinax/stripe/views.py 100% <0%> (ø) ⬆️
pinax/stripe/models.py 100% <0%> (ø) ⬆️
pinax/stripe/middleware.py 100% <0%> (ø) ⬆️
pinax/stripe/forms.py 100% <0%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b67b87...e45b225. Read the comment docs.

@paltman
Copy link
Member

paltman commented Oct 30, 2017

@grahamu i went ahead and took care of it. we should figure out how/why your local linting works differently than CI

@paltman paltman merged commit 2c0d585 into master Oct 30, 2017
@paltman paltman deleted the fix-readme-matrix branch January 20, 2019 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants