Revert "CircleCI: test merge commit" #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3103cff. As outlined in [1] it causes issues with Codecov, when we report coverage for the merge commit, but it is then applied to the commit itself. 1: pinax#422 (comment)
Codecov Report
@@ Coverage Diff @@
## master #465 +/- ##
=======================================
Coverage 99.52% 99.52%
=======================================
Files 34 34
Lines 1699 1699
Branches 147 147
=======================================
Hits 1691 1691
Misses 4 4
Partials 4 4
Continue to review full report at Codecov.
|
|
Thanks for trusting me on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3103cff.
As outlined in [1] it causes issues with Codecov, when we report
coverage for the merge commit, but it is then applied to the commit
itself.
1: #422 (comment)