Delete unused code (#286)

pinchbv · Mar 15, 2020 · cd9d744 · cd9d744
1 parent 2c75e88
commit cd9d744
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 70 deletions.
diff --git a/floor_generator/lib/value_object/view.dart b/floor_generator/lib/value_object/view.dart
@@ -7,34 +7,19 @@ import 'package:floor_generator/value_object/queryable.dart';
 class View extends Queryable {
   final String query;
 
-  View(ClassElement classElement, String name, List<Field> fields, this.query,
-      String constructor)
-      : super(classElement, name, fields, constructor);
+  View(
+    ClassElement classElement,
+    String name,
+    List<Field> fields,
+    this.query,
+    String constructor,
+  ) : super(classElement, name, fields, constructor);
 
   @nonNull
   String getCreateViewStatement() {
     return 'CREATE VIEW IF NOT EXISTS `$name` AS $query';
   }
 
-  @nonNull
-  String getValueMapping() {
-    final keyValueList = fields.map((field) {
-      final columnName = field.columnName;
-      final attributeValue = _getAttributeValue(field.fieldElement);
-      return "'$columnName': $attributeValue";
-    }).toList();
-
-    return '<String, dynamic>{${keyValueList.join(', ')}}';
-  }
-
-  @nonNull
-  String _getAttributeValue(final FieldElement fieldElement) {
-    final parameterName = fieldElement.displayName;
-    return fieldElement.type.isDartCoreBool
-        ? 'item.$parameterName ? 1 : 0'
-        : 'item.$parameterName';
-  }
-
   @override
   bool operator ==(Object other) =>
       identical(this, other) ||

diff --git a/floor_generator/test/value_object/view_test.dart b/floor_generator/test/value_object/view_test.dart
@@ -1,6 +1,6 @@
 import 'package:floor_generator/misc/constants.dart';
-import 'package:floor_generator/value_object/view.dart';
 import 'package:floor_generator/value_object/field.dart';
+import 'package:floor_generator/value_object/view.dart';
 import 'package:mockito/mockito.dart';
 import 'package:test/test.dart';
 
@@ -36,59 +36,19 @@ void main() {
     reset(mockDartType);
   });
 
-  group('statement', () {
-    test('Create view statement with simple query', () {
-      final view = View(
-        mockClassElement,
-        'entityName',
-        allFields,
-        'select * from x',
-        '',
-      );
-
-      final actual = view.getCreateViewStatement();
-
-      final expected =
-          'CREATE VIEW IF NOT EXISTS `${view.name}` AS ${view.query}';
-      expect(actual, equals(expected));
-    });
-  });
-
-  group('Value mapping', () {
+  test('Create view statement with simple query', () {
     final view = View(
       mockClassElement,
       'entityName',
-      [nullableField],
-      'select * from x',
+      allFields,
+      'SELECT * FROM x',
       '',
     );
-    const fieldElementDisplayName = 'foo';
-
-    setUp(() {
-      when(mockFieldElement.displayName).thenReturn(fieldElementDisplayName);
-      when(mockFieldElement.type).thenReturn(mockDartType);
-    });
-
-    test('Get value mapping', () {
-      when(mockDartType.isDartCoreBool).thenReturn(false);
-
-      final actual = view.getValueMapping();
-
-      final expected = '<String, dynamic>{'
-          "'${nullableField.columnName}': item.$fieldElementDisplayName"
-          '}';
-      expect(actual, equals(expected));
-    });
-
-    test('Get boolean value mapping', () {
-      when(mockDartType.isDartCoreBool).thenReturn(true);
 
-      final actual = view.getValueMapping();
+    final actual = view.getCreateViewStatement();
 
-      final expected = '<String, dynamic>{'
-          "'${nullableField.columnName}': item.$fieldElementDisplayName ? 1 : 0"
-          '}';
-      expect(actual, equals(expected));
-    });
+    final expected =
+        'CREATE VIEW IF NOT EXISTS `${view.name}` AS ${view.query}';
+    expect(actual, equals(expected));
   });
 }