enum custom TypeConverters not working

[zhangruiyu]

I have defined the Converter as documented, but it has no effect on the enumeration

[zhangruiyu]

I think that's the right answer, but that's not what's being generated so far

[dkaera]

@zhangruiyu good catch
TypeConverters has a lower priority than supported Dart types. Since floor supports Dart enumerations out of the box, you cannot override this. I think we can change this rule it in the next release.

[dkaera]

@zhangruiyu
but in any case, floor supports Dart enumerations without TypeConverter and stores them in the appropriate column with int type. If that's fine with you, you don't have to declare TypeConverter for enumerations.

[zhangruiyu]

@zhangruiyu
but in any case, floor supports Dart enumerations without TypeConverter and stores them in the appropriate column with int type. If that's fine with you, you don't have to declare TypeConverter for enumerations.

Normally this is fine, but dart now supports byname, which can be problematic if the enumeration changes with version updates (for example, adding a new enumeration between two)

[zhangruiyu]

As you said earlier, type converter should have a higher priority

[zhangruiyu]

For example isar, which I think the floor should support

[dkaera]

Oh, that's a good one.
I was just thinking about how to implement backward compatibility support.
Not sure about the second option ordinal32. The value of any column can be null if necessary. The number of enum declarations can be unlimited, at least I have not found any limit. What is the benefit of this approach?

[taosimple]

I have the same issue, after upgrade code is broken, is there any work around.

[dkaera]

PR that changes TypeConverters priority is ready for review. #740
Default String converters support will be later.

[zhangruiyu]

PR that changes TypeConverters priority is ready for review. #740
Default String converters support will be later.

Great. When will the new version be released, thank you very much

[dkaera]

PR that changes TypeConverters priority is ready for review. #740
Default String converters support will be later.

Great. When will the new version be released, thank you very much

as soon as PINCH team approve it. I'm just a contributor 😁