-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed TypeConverters priority. Exist TypeConverter performs first, … #740
Changed TypeConverters priority. Exist TypeConverter performs first, … #740
Conversation
…even the column/model field type is a supported SQL type.
Codecov Report
@@ Coverage Diff @@
## develop #740 +/- ##
========================================
Coverage 90.76% 90.76%
========================================
Files 11 11
Lines 195 195
========================================
Hits 177 177
Misses 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@@ -65,7 +65,8 @@ class TasksWidgetState extends State<TasksWidget> { | |||
PopupMenuButton<int>( | |||
itemBuilder: (context) { | |||
return List.generate( | |||
TaskType.values.length + 1, //Uses increment to handle All types | |||
TaskStatus.values.length + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: was this supposed to be a new line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auto-formatting moved it to a new line
it makes sense to remove the comment at the end of line
Hello, when will the new version be released |
Thomas fell ill, so we're waiting for him to recover. |
I'm sorry to bother you again. When can we release the new version? It's been 4 months since the last update. Sorry to bother you again |
Yes, we're in the same boat. I'm waiting for a review too, but there haven't been any updates. |
Changed TypeConverters priority. Exist TypeConverter performs first, even the column/model field type is a supported SQL type.
Fixes issue #735