Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed TypeConverters priority. Exist TypeConverter performs first, … #740

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

dkaera
Copy link
Collaborator

@dkaera dkaera commented Mar 4, 2023

Changed TypeConverters priority. Exist TypeConverter performs first, even the column/model field type is a supported SQL type.
Fixes issue #735

…even the column/model field type is a supported SQL type.
@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

Merging #740 (80bae7e) into develop (ae4b2c8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #740   +/-   ##
========================================
  Coverage    90.76%   90.76%           
========================================
  Files           11       11           
  Lines          195      195           
========================================
  Hits           177      177           
  Misses          18       18           
Flag Coverage Δ
floor 90.76% <ø> (ø)
floor_generator ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -65,7 +65,8 @@ class TasksWidgetState extends State<TasksWidget> {
PopupMenuButton<int>(
itemBuilder: (context) {
return List.generate(
TaskType.values.length + 1, //Uses increment to handle All types
TaskStatus.values.length +

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: was this supposed to be a new line?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto-formatting moved it to a new line
it makes sense to remove the comment at the end of line

@zhangruiyu
Copy link

Hello, when will the new version be released

@dkaera
Copy link
Collaborator Author

dkaera commented Mar 20, 2023

Hello, when will the new version be released

Thomas fell ill, so we're waiting for him to recover.

@zhangruiyu
Copy link

I'm sorry to bother you again. When can we release the new version? It's been 4 months since the last update. Sorry to bother you again

@dkaera
Copy link
Collaborator Author

dkaera commented Apr 18, 2023

I'm sorry to bother you again. When can we release the new version? It's been 4 months since the last update. Sorry to bother you again

Yes, we're in the same boat. I'm waiting for a review too, but there haven't been any updates.

@dkaera dkaera merged commit bb74673 into pinchbv:develop Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants