Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more convenient database initialization #116

Merged
merged 4 commits into from
Apr 8, 2019

Conversation

vitusortner
Copy link
Collaborator

This PR also introduces the functionality for customizing the name of the database file.

Resolves #100.

@vitusortner vitusortner added the feature Request and implementation of a feature (release drafter) label Apr 6, 2019
@codecov
Copy link

codecov bot commented Apr 6, 2019

Codecov Report

Merging #116 into develop will increase coverage by 1.44%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #116      +/-   ##
===========================================
+ Coverage    68.69%   70.13%   +1.44%     
===========================================
  Files           46       48       +2     
  Lines         1265     1326      +61     
===========================================
+ Hits           869      930      +61     
  Misses         396      396
Impacted Files Coverage Δ
floor_generator/lib/writer/database_writer.dart 75% <100%> (+0.45%) ⬆️
floor_generator/lib/writer/floor_writer.dart 100% <100%> (ø)
..._generator/lib/writer/database_builder_writer.dart 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78136f4...9bb5642. Read the comment docs.

@vitusortner vitusortner merged commit 5067cc7 into develop Apr 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the custom-database-name branch April 8, 2019 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Request and implementation of a feature (release drafter)
Development

Successfully merging this pull request may close these issues.

1 participant