Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude static fields from entity mapping #233

Merged
merged 5 commits into from
Jan 24, 2020
Merged

Exclude static fields from entity mapping #233

merged 5 commits into from
Jan 24, 2020

Conversation

finger-software
Copy link
Contributor

@finger-software finger-software commented Jan 17, 2020

The static fields are excluded from the field list for mapping.

Closes #231

The static fields are excluded from the field list for mapping.
@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #233 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #233   +/-   ##
========================================
  Coverage    80.69%   80.69%           
========================================
  Files           50       50           
  Lines         1383     1383           
========================================
  Hits          1116     1116           
  Misses         267      267

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cedf770...54fafa0. Read the comment docs.

@vitusortner
Copy link
Collaborator

Thanks for your contribution! I'll add tests for the new code to then merge it.

@vitusortner vitusortner changed the title Fix issue #231 Don't map static fields Jan 24, 2020
@vitusortner vitusortner changed the title Don't map static fields Exclude static fields from entity mapping Jan 24, 2020
@vitusortner vitusortner merged commit d9f1689 into pinchbv:develop Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Static fields should not be included in the mapping
2 participants