Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Getters&Setters #279

Merged
merged 5 commits into from
Mar 14, 2020
Merged

Ignore Getters&Setters #279

merged 5 commits into from
Mar 14, 2020

Conversation

mqus
Copy link
Collaborator

@mqus mqus commented Mar 11, 2020

Fixes #272 and fixes #260 by ignoring synthetic fields(getters and setters) entirely.

Should i also remove the isHashCode check? it seems redundant now...

Do you want any documentation for this or would you prefer to do it yourself?

@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #279 into develop will decrease coverage by 0.68%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #279      +/-   ##
===========================================
- Coverage    81.28%   80.59%   -0.69%     
===========================================
  Files           51       43       -8     
  Lines         1384     1201     -183     
===========================================
- Hits          1125      968     -157     
+ Misses         259      233      -26     
Flag Coverage Δ
#floor ?
#floor_generator 80.59% <100.00%> (-0.02%) ⬇️
Impacted Files Coverage Δ
...loor_generator/lib/processor/entity_processor.dart 78.26% <100.00%> (-0.16%) ⬇️
floor/lib/src/adapter/query_adapter.dart
floor/lib/src/util/primary_key_helper.dart
floor/lib/src/callback.dart
floor/lib/src/adapter/migration_adapter.dart
floor/lib/src/migration.dart
floor/lib/src/adapter/insertion_adapter.dart
floor/lib/src/adapter/deletion_adapter.dart
floor/lib/src/adapter/update_adapter.dart

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e47af1...2ff16db. Read the comment docs.

Copy link
Collaborator

@vitusortner vitusortner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🎉

Do you want any documentation for this or would you prefer to do it yourself?

It'd be nice if could update the README.md's and floor/README.md's (they hold the same information) "Ignoring Fields" section. hashCode, static fields and getters (I do think that setters were never included) are now excluded from the library's mapping.

floor_generator/lib/processor/entity_processor.dart Outdated Show resolved Hide resolved
floor_generator/test/processor/entity_processor_test.dart Outdated Show resolved Hide resolved
floor_generator/test/processor/entity_processor_test.dart Outdated Show resolved Hide resolved
floor/README.md Outdated Show resolved Hide resolved
floor/README.md Outdated Show resolved Hide resolved
@vitusortner
Copy link
Collaborator

I've fixed the failing floor CI job. These changes are now available on the develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

How to use ignore annotation? Exclude getters and setters from mapping
2 participants