-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore Getters&Setters #279
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #279 +/- ##
===========================================
- Coverage 81.28% 80.59% -0.69%
===========================================
Files 51 43 -8
Lines 1384 1201 -183
===========================================
- Hits 1125 968 -157
+ Misses 259 233 -26
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! 🎉
Do you want any documentation for this or would you prefer to do it yourself?
It'd be nice if could update the README.md
's and floor/README.md
's (they hold the same information) "Ignoring Fields" section. hashCode
, static fields and getters (I do think that setters were never included) are now excluded from the library's mapping.
I've fixed the failing floor CI job. These changes are now available on the |
Fixes #272 and fixes #260 by ignoring synthetic fields(getters and setters) entirely.
Should i also remove the
isHashCode
check? it seems redundant now...Do you want any documentation for this or would you prefer to do it yourself?