Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrongly parsed arguments in @Query #322

Merged
merged 1 commit into from
May 6, 2020
Merged

Fix wrongly parsed arguments in @Query #322

merged 1 commit into from
May 6, 2020

Conversation

mqus
Copy link
Collaborator

@mqus mqus commented May 5, 2020

Fixes the issue (interpreting commas as parts of the inserted argument) by narrowing down the regex to only include letters, numbers, . and _.

For github: fixes #223 (NOT 224, that was a typo, I'll update the commit message)

@mqus mqus changed the title Fix issue #224 Fix wrongly parsed arguments in @Query May 5, 2020
@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #322 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #322   +/-   ##
========================================
  Coverage    81.55%   81.55%           
========================================
  Files           57       57           
  Lines         1475     1475           
========================================
  Hits          1203     1203           
  Misses         272      272           
Flag Coverage Δ
#floor 81.55% <100.00%> (ø)
#floor_generator 80.97% <100.00%> (ø)
Impacted Files Coverage Δ
...enerator/lib/processor/query_method_processor.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfa25d3...474519d. Read the comment docs.

@mqus mqus requested a review from vitusortner May 5, 2020 18:49
@mqus mqus added the fix Implementation of a bug fix (release drafter) label May 5, 2020
Copy link
Collaborator

@vitusortner vitusortner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks 👍

@mqus mqus merged commit c9fb818 into develop May 6, 2020
@mqus mqus deleted the fix-comma-slurping branch May 6, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Implementation of a bug fix (release drafter)
Development

Successfully merging this pull request may close these issues.

[0.6.0] Incorrect generated query if updating multiple columns
2 participants