Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix desktop database path retrieval #475

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

vitusortner
Copy link
Collaborator

We're now referring to the abstract DatabaseFactory.getDatabasesPath instead of the mobile implementation (can be found at sqflite.getDatabasesPath).

Closes #474

@vitusortner vitusortner marked this pull request as ready for review January 5, 2021 18:51
@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #475 (b72be61) into develop (5d9c888) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #475   +/-   ##
========================================
  Coverage    83.40%   83.40%           
========================================
  Files           68       68           
  Lines         1687     1687           
========================================
  Hits          1407     1407           
  Misses         280      280           
Flag Coverage Δ
floor 83.40% <0.00%> (ø)
floor_generator 83.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
floor/lib/src/sqflite_database_factory.dart 54.54% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d9c888...b72be61. Read the comment docs.

@vitusortner vitusortner merged commit cfc9e5b into develop Jan 5, 2021
@vitusortner vitusortner deleted the fix-desktop-database-path branch January 5, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

windows flutter: MissingPluginException
1 participant