Increase test coverage #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #539 +/- ##
==========================================
Coverage ? 90.04%
==========================================
Files ? 74
Lines ? 1858
Branches ? 0
==========================================
Hits ? 1673
Misses ? 185
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
vitusortner
approved these changes
Apr 22, 2021
| @@ -25,7 +27,7 @@ class Index { | |||
| name == other.name && | |||
| tableName == other.tableName && | |||
| unique == other.unique && | |||
| columnNames == other.columnNames; | |||
| const ListEquality<String>().equals(columnNames, other.columnNames); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pushes the test coverage over the magic 90% :)
Some errors from the change method processors were pulled out but the rest is pretty much just more tests.
I tried to tackle the biggest target in the codecov heatmap,
value_objects, but while theequalsmethods seem simple, thehashCodemethods are wrong in most cases, because thehashCodeof dartElements can be different even if the dart elements themselves are equal (==). But the value objects also don't really benefit all that much from testing since they only have trivial methods left.So I took the next best target, error messages. Aside from those there are only two tests (database writer with daoGetters and entity processor with indices) that cover something else. I catched a single issue where the equals method of
Indexwas not 100% correct(should only be an internal problem at the very most, if it mattered at all) but nothing apart from that.There is also one test that I had to set to
skipbecause I could not figure out how to trigger that specific error message (EntityProcessorError.foreignKeyDoesNotReferenceEntity). I can also remove that if there is no "solution" ;)