-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented change notification when a table changes by the query. #733
Merged
ThomasMiddel
merged 8 commits into
pinchbv:develop
from
dkaera:feature/notify_on_query_modify_table
Apr 20, 2023
Merged
Implemented change notification when a table changes by the query. #733
ThomasMiddel
merged 8 commits into
pinchbv:develop
from
dkaera:feature/notify_on_query_modify_table
Apr 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the query. Added simple tests.
dkaera
requested review from
mqus,
vitusortner,
ThomasMiddel and
MobilePinch
February 11, 2023 18:12
Codecov Report
@@ Coverage Diff @@
## develop #733 +/- ##
===========================================
+ Coverage 90.76% 91.92% +1.15%
===========================================
Files 11 11
Lines 195 223 +28
===========================================
+ Hits 177 205 +28
Misses 18 18
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Closed
dkaera
force-pushed
the
feature/notify_on_query_modify_table
branch
from
February 11, 2023 18:25
afbdd07
to
f78c6b6
Compare
…for query adapter.
dkaera
force-pushed
the
feature/notify_on_query_modify_table
branch
from
February 11, 2023 21:19
aca7147
to
a3bcff6
Compare
dkaera
force-pushed
the
feature/notify_on_query_modify_table
branch
from
February 11, 2023 21:24
a3bcff6
to
aee2e18
Compare
memoriasIT
previously approved these changes
Mar 7, 2023
ThomasMiddel
previously approved these changes
Apr 18, 2023
…y_on_query_modify_table
…y_on_query_modify_table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #731