Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nightly-release workflow and tweak Poetry package naming #208

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix nightly-release workflow and tweak Poetry package naming #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .github/workflows/nightly-release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3

- name: Get recent changes
id: list-commits
run: |
Expand All @@ -31,19 +31,19 @@ jobs:
- name: Set dev version
id: version
run: |
versionFile="pinecone/__version__"
currentDate=$(date +%Y%m%d%H%M%S)
versionNumber=$(cat $versionFile)
devVersion="${versionNumber}.dev${currentDate}"
echo "$devVersion" > $versionFile
versionFile="pinecone/__version__"
currentDate=$(date +%Y%m%d%H%M%S)
versionNumber=$(cat $versionFile)
devVersion="${versionNumber}.dev${currentDate}"
echo "$devVersion" > $versionFile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks reasonable to me. I was trying to think of some edge cases where it would be possible to perform a partial or incomplete version bump, but theoretically if any of these subcommand were to fail, the step itself would fail and then the GitHub Action job would fail.


- name: Adjust module name
run: |
sed -i 's/pinecone-client/pinecone-client-nightly/g' setup.py
sed -i 's/pinecone-client/pinecone-client-nightly/g' pyproject.toml

- name: Update README
run: |
echo "This is a nightly developer build of the Pinecone Python client. It is not intended for production use." > README.md
echo "This is a nightly developer build of the Pinecone Python client. It is not intended for production use." > README.md

- uses: actions/setup-python@v4
with:
Expand Down
5 changes: 4 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,11 @@ exclude = '''
'''

[tool.poetry]
name = "pinecone"
name = "pinecone-client"
Copy link
Contributor

@zackproser zackproser Oct 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I went back and forth on this name value in my original Poetry PR from pinecone-client back to pinecone to get everything working. However your explanation in the PR description makes sense to me.

version = "2.2.4"
packages = [
{ include="pinecone", from="." },
]
Comment on lines +27 to +29
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read up on this and it makes sense to me.

description = "Pinecone client and SDK"
authors = ["Pinecone Systems, Inc. <[email protected]>"]
license = "Apache-2.0"
Expand Down