Add new setup-poetry action and fix nightly-release #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by using the action, apply to other relevant workflows
austin-denoble
commented
Oct 4, 2023
|
|
||
| - name: Set up Git | ||
| run: | | ||
| git config --global user.name "Pinecone CI" | ||
| git config --global user.email "[email protected]" | ||
|
|
There was a problem hiding this comment.
Moved this up, did a tiny bit of organizing steps in here.
austin-denoble
commented
Oct 4, 2023
Comment on lines
-47
to
-48
| - name: Build Project | ||
| run: poetry build |
There was a problem hiding this comment.
Removed, we're calling make package above which is essentially an alias for poetry build, don't think we need to call it again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
nightly-releaseworkflow is still failing after the previous "fix": #208.This time it's due to
make packagefailing onpoetry build, becausepoetrywasn't setup properly in the workflow.https://github.com/pinecone-io/pinecone-python-client/actions/runs/6399744230/job/17372332268
While fixing this I noticed we're also not installing Poetry in the
publish-to-pypiworkflow, so callingpoetry versionandmakecommands there would fail. We need to make sure we're installing Poetry properly before usingmakein our workflows, as they call Poetry under the hood.Solution
setup-poetryaction that encapsulates the install + dependencies bits. I noticed we were doing this explicitly in several workflows and thought it called for an action.nightly-releaseworfklow: call the new action before callingmake package.release-to-pypiworfklow: call the new action before callingpoetry version, andmakecommands for publishing.testingworfklow.Type of Change
Test Plan
Validate PR workflows pass as expected. Merge and check
nightly-releaseto make sure we're in good shape.