Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

live.Downloader's output file corruption #5

Closed
4 of 7 tasks
ping opened this issue May 26, 2017 · 1 comment
Closed
4 of 7 tasks

live.Downloader's output file corruption #5

ping opened this issue May 26, 2017 · 1 comment
Assignees
Labels

Comments

@ping
Copy link
Owner

ping commented May 26, 2017

Please follow the guide below

  • Issues submitted without this template format will be ignored.
  • You will be asked some questions and requested to provide some information, please read them carefully and answer completely.
  • Do not post screenshots of error messages or code.
  • Put an x into all the boxes [ ] relevant to your issue (like so [x]).
  • Use the Preview tab to see how your issue will actually look like.

Before submitting an issue make sure you have:

Purpose of your issue?

  • Bug report (encountered problems/errors)
  • Feature request (request for a new functionality)
  • Question
  • Other

Describe your issue

An IG stream sometimes, possibly due to bandwidth, starts with a low resolution for the first second before stepping up to return higher-resolution segments. This results in the first segment saved (usually XXXXX-0.m4v) having a smaller resolution than the rest of the subsequent segments.

This situation causes a corrupted file when the segments are merged.

@ping ping added the bug label May 26, 2017
@ping ping self-assigned this May 26, 2017
ping added a commit that referenced this issue May 27, 2017
@ping
Copy link
Owner Author

ping commented May 27, 2017

Changes in 2839027:

  • If a change in resolution is detected, the downloader will
    attempt to generate a separate video file.

  • As a result, downloader.stitch() now returns list of generated filenames.

  • The filename format for these separate files are:
    <output_filename>-<n>.mp4

  • The Downloader also has a new property segment_meta, a dict with a structure similar to:

    {
        "XXXXXXXXXXXXXXXX-0.m4v": "324p"
        "XXXXXXXXXXXXXXXX-1001.m4v": "480p",
        "XXXXXXXXXXXXXXXX-1002.m4v": "480p",
        "XXXXXXXXXXXXXXXX-1003.m4v": "480p"
    }

    where the dict keys are the video segment names and the
    corresponding value is the resolution label (may vary). You may wish to store this segment meta information if you want to process the segments manually instead of relying on downloader.stitch().

@ping ping closed this as completed Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant