Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

backup: allow backup tolerate minor TiKV failure (#997) #1019

Merged
merged 3 commits into from
Apr 15, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Apr 15, 2021

cherry-pick #997 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In br repo:
git pr https://github.com/pingcap/br/pull/1019

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/br.git pr/1019:release-5.0-db863d52a070

What problem does this PR solve?

fixed #980

What is changed and how it works?

ignore all ‘failed to connect to store’ errors during backup.

Check List

Tests

  • Integration test

Release Note

  • BR now can tolerate minor TiKV disconnection.

@YuJuncen
Copy link
Collaborator

/run-integration-tests

2 similar comments
@YuJuncen
Copy link
Collaborator

/run-integration-tests

@YuJuncen
Copy link
Collaborator

/run-integration-tests

@3pointer 3pointer added this to the v5.0.1 milestone Apr 15, 2021
@3pointer
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Apr 15, 2021
@YuJuncen
Copy link
Collaborator

/run-integration-tests

@lichunzhu
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Apr 15, 2021
@3pointer
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b0919cf

@ti-chi-bot ti-chi-bot merged commit 264059b into pingcap:release-5.0 Apr 15, 2021
ti-srebot added a commit to ti-srebot/br that referenced this pull request Apr 26, 2021
@ti-srebot
Copy link
Contributor Author

cherry pick to release-4.0 in PR #1062

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants