Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

backup: debounce fine-grained backup (#1036) #1037

Merged
merged 6 commits into from
May 27, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Apr 20, 2021

cherry-pick #1036 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In br repo:
git pr https://github.com/pingcap/br/pull/1037

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/br.git pr/1037:release-5.0-55f18432033b

What problem does this PR solve?

Sometimes, TiKV make empty response stream from backing up request. (This seems buggy, but not sure.)

In this condition, fine-grained backup would crazily send backup RPC, if there are enough resource, thing wouldn't be so bad: when PD make progress, real leader can be found, and everything should back to normal, but for our CI, the busiest node of our community, un, ya see.

Note the timestamp. There are about 100k+ or even more logs like this.

image

What is changed and how it works?

Now, if fine-grained backup make no progress, it would backoff for 10 seconds.
The backoff time is an experience value, by analyzing the local log. Let's change it if necessary.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release Note

  • Fix a bug that caused BR send too many useless RPCs to TiKV.

@glorv
Copy link
Collaborator

glorv commented Apr 20, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Apr 20, 2021
@kennytm
Copy link
Collaborator

kennytm commented Apr 20, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Apr 20, 2021
@kennytm
Copy link
Collaborator

kennytm commented Apr 20, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 714d1ca

@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@3pointer
Copy link
Collaborator

/merge

@ti-chi-bot ti-chi-bot merged commit 28cd7a4 into pingcap:release-5.0 May 27, 2021
@Leavrth Leavrth added this to the v5.0.2 milestone May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants